drivers/st77xx: implement initialization #19827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
github-actions
bot
added
Area: doc
gschorcht
added
Type: bug
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
2 times, most recently
from
8278df3 to
de203bc
Compare
benpicco
added
the
State: waiting for other PR
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
3 times, most recently
from
60b7abc to
6b81b5f
Compare
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
from
6b81b5f to
bbfa0bd
Compare
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
from
d6b06a4 to
e50ecaf
Compare
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
19824: boards/sipeed_longan_nano: separate board definition for Sipeed Longan Nano TFT r=benpicco a=gschorcht ### Contribution description This PR provides a minimal separate board definition for the Sipeed Longan Nano version with TFT display which is just an extension of `boards/sipeed-longan-nano` with enabled TFT display module. From the lessons we had to learn with the Kconfig modelling of optional hardware, the TFT version of the Sipeed Longan Nano board has been split off into its own board definition based on the existing Siepeed Longan Nano board. Commits ba29a5e, 237819e, 6d8b56d and c5faf34 are small cleanups of peripheral configurations and could be split from this PR as follow-up PR (changes +70 -36). ### Testing procedure Green CI ``` BOARD=sipeed-longan-nano-tft make -j8 -C tests/drivers/st77xx flash ``` should work ### Issues/PRs references Follow up to PR #19813 and PR #19814 Prerequisite for PR #19825 and PR #19827 19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco Co-authored-by: Gunar Schorcht <gunar@schorcht.net> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de>
gschorcht
changed the title
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
19824: boards/sipeed_longan_nano: separate board definition for Sipeed Longan Nano TFT r=benpicco a=gschorcht ### Contribution description This PR provides a minimal separate board definition for the Sipeed Longan Nano version with TFT display which is just an extension of `boards/sipeed-longan-nano` with enabled TFT display module. From the lessons we had to learn with the Kconfig modelling of optional hardware, the TFT version of the Sipeed Longan Nano board has been split off into its own board definition based on the existing Siepeed Longan Nano board. Commits ba29a5e, 237819e, 6d8b56d and c5faf34 are small cleanups of peripheral configurations and could be split from this PR as follow-up PR (changes +70 -36). ### Testing procedure Green CI ``` BOARD=sipeed-longan-nano-tft make -j8 -C tests/drivers/st77xx flash ``` should work ### Issues/PRs references Follow up to PR #19813 and PR #19814 Prerequisite for PR #19825 and PR #19827 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
bors bot
added a commit
that referenced
this pull request
Aug 7, 2023
19824: boards/sipeed_longan_nano: separate board definition for Sipeed Longan Nano TFT r=benpicco a=gschorcht ### Contribution description This PR provides a minimal separate board definition for the Sipeed Longan Nano version with TFT display which is just an extension of `boards/sipeed-longan-nano` with enabled TFT display module. From the lessons we had to learn with the Kconfig modelling of optional hardware, the TFT version of the Sipeed Longan Nano board has been split off into its own board definition based on the existing Siepeed Longan Nano board. Commits ba29a5e, 237819e, 6d8b56d and c5faf34 are small cleanups of peripheral configurations and could be split from this PR as follow-up PR (changes +70 -36). ### Testing procedure Green CI ``` BOARD=sipeed-longan-nano-tft make -j8 -C tests/drivers/st77xx flash ``` should work ### Issues/PRs references Follow up to PR #19813 and PR #19814 Prerequisite for PR #19825 and PR #19827 19855: gnrc_static: fix static PID assignment r=benpicco a=benpicco 19862: cpu/riscv_common: remove picolibc from blacklisting in CI r=benpicco a=gschorcht ### Contribution description `picolibc` is now supported by the RISC-V toolchain in `riotdocker`. It is not necessary to blacklist it in CI any longer. Reference: `picolib` was blacklisted by commit 45270da in PR #15011. ### Testing procedure 1. Green CI 2. Check feature list for CI compilation: ``` BUILD_IN_DOCKER=1 RIOT_CI_BUILD=1 FEATURES_OPTIONAL=picolibc \ BOARD=sipeed-longan-nano make -j8 -C tests/sys/shell info-modules | grep picolib picolibc picolibc_stdout_buffered picolibc_syscalls_default ``` ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net> Co-authored-by: Benjamin Valentin <benjamin.valentin@bht-berlin.de>
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
from
e50ecaf to
8b0be60
Compare
4 tasks
bors bot
added a commit
that referenced
this pull request
Sep 6, 2023
19825: drivers: rename st7735 to more generic st77xx r=aabadie a=gschorcht ### Contribution description This PR provides the following changes: - renames the driver `st7735` to `st77xx` - renames the test `st7735` to `st77xx` - models controller variants as pseudomodules `st7735`, `st7789` and `st7796` - removes the buggy initialization as a workaround to use reset defaults, see issue #19818 - adds backward compatibility header files for `ST7735_PARAM_*` symbols - adds a test board for compilation test of backward compatibility - updates the corresponding board definitions The PR should solve the remaining dependency issues in KConfig we had by using `st7735` module for different controller variants. The backward compatibility header files should work for boards that still use `ST7735_PARAM_*` in their board definitions so that the board defintions at user's side use shouldn't be affected. ~To be compilable, the PR includes PR #19824.~ ### Testing procedure - Green CI - `tests/drivers/disp_dev` and `tests/drivers/st77xx` should still work for all boards using a ST77xx display. - The PR was already tested for these tests for: - [x] `adafruit-pybadge` - [x] `esp32s2-lilygo-ttgo-t8` - [x] `esp32s3-usb-otg` - [x] `sipeed-longan-nano` ### Issues/PRs references Workaround for issue #19818 Preqruisite for PR #19827 Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
from
8b0be60 to
aec762e
Compare
github-actions
bot
removed
Area: tests
gschorcht
removed
the
State: waiting for other PR
aabadie
reviewed
Sep 6, 2023
aabadie
reviewed
Sep 6, 2023
aabadie
reviewed
Sep 6, 2023
|
Just tested this on a custom setup (adafruit st7735 breakout connected to a nucleo 64 board). I have something weird: the screen is 128x128 but to get something really perfect I have to set this parameters: #define ST77XX_PARAM_NUM_LINES (130U) /**< Number of screen lines */
#define ST77XX_PARAM_RGB_CHANNELS (130U) /**< Number of screen rgb channel (height) */Do you have any idea what could cause this? (on master it crashes...) For reference this is the configuration I use on the nucleo board: diff --git a/drivers/st77xx/include/st7735_params.h b/drivers/st77xx/include/st7735_params.h
index a137f1da71..985aff21d1 100644
--- a/drivers/st77xx/include/st7735_params.h
+++ b/drivers/st77xx/include/st7735_params.h
@@ -30,6 +30,25 @@
#include "board.h"
#include "lcd.h"
+
+/**
+ * @name Display configuration (not supported yet)
+ * @{
+ */
+#define ST77XX_PARAM_CNTRL ST77XX_CNTRL_ST7735 /**< ST77xx controller variant */
+#define ST77XX_PARAM_SPI SPI_DEV(0) /**< SPI device */
+#define ST77XX_PARAM_CS GPIO_PIN(1, 6) /**< Chip select pin */
+#define ST77XX_PARAM_DCX GPIO_PIN(0, 9) /**< DCX pin */
+#define ST77XX_PARAM_RST GPIO_PIN(2, 7) /**< Reset pin */
+#define ST77XX_PARAM_NUM_LINES (130U) /**< Number of screen lines */
+#define ST77XX_PARAM_RGB_CHANNELS (130U) /**< Number of screen rgb channel (height) */
+#define ST77XX_PARAM_RGB (0) /**< RGB configuration */
+#define ST77XX_PARAM_INVERTED (0) /**< Inversion configuration */
+#define ST77XX_PARAM_ROTATION (ST77XX_ROTATION_HORZ_FLIP) /**< Rotation mode */
+#define LCD_SCREEN_WIDTH (ST77XX_PARAM_NUM_LINES) /**< LCD screen width */
+#define LCD_SCREEN_HEIGHT (ST77XX_PARAM_RGB_CHANNELS) /**< LCD screen height */
+/** @} */
+
#include "st7735.h"
#ifdef __cplusplus |
|
I guess you need to set
I guess you have the Adafruit 1.44" Color TFT LCD Display with MicroSD Card breakout - ST7735R. I found in the Python Usage page the following comment for this display: So you could try #define ST77XX_PARAM_NUM_LINES (128U) /**< Number of screen lines */
#define ST77XX_PARAM_RGB_CHANNELS (128U) /**< Number of screen rgb channel (height) */
#define ST77XX_PARAM_OFFSET_X (2)
#define ST77XX_PARAM_OFFSET_Y (3) |
Good point that was that! Just setting |
gschorcht
force-pushed
the
drivers/st77xx_fix_init_single_module
branch
from
12143bd to
7599ce7
Compare
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
@aabadie Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR implements correct initialization for ST7735, ST7789 and ST7796. A number of configuration parameters are exposed via Kconfig. The user can decide whether to use custom configuration parameters or reset defaults.
To be compilable, the PR includes PR #19824 and PR #19825Testing procedure
tests/drivers/disp_devandtests/drivers/st77xxshould still work for all boards using a ST77xx display.adafruit-pybadgeesp32s2-lilygo-ttgo-t8esp32s3-usb-otgsipeed-longan-nanoIssues/PRs references
Depends on #19825Fixes #19818